Add dynamic stage built events - #570
Open
gabotechs wants to merge 2 commits into
Open
Conversation
This was referenced Jul 27, 2026
gabotechs
force-pushed
the
gabrielmusat/async-desired-task-count
branch
2 times, most recently
from
July 27, 2026 08:53
ca40839 to
30bbc84
Compare
gabotechs
force-pushed
the
gabrielmusat/dynamic-stage-built-events
branch
from
July 27, 2026 08:53
fdb1562 to
4ccf26f
Compare
gabotechs
force-pushed
the
gabrielmusat/async-desired-task-count
branch
from
July 27, 2026 09:05
30bbc84 to
9ff5732
Compare
gabotechs
force-pushed
the
gabrielmusat/dynamic-stage-built-events
branch
from
July 27, 2026 09:05
4ccf26f to
d8fdb19
Compare
gabotechs
marked this pull request as ready for review
July 27, 2026 09:54
gabotechs
force-pushed
the
gabrielmusat/async-desired-task-count
branch
2 times, most recently
from
July 28, 2026 09:20
6846880 to
a6ac3d4
Compare
gabotechs
force-pushed
the
gabrielmusat/dynamic-stage-built-events
branch
from
July 28, 2026 09:21
b0f2fe8 to
700d9ca
Compare
gabotechs
added a commit
that referenced
this pull request
Jul 28, 2026
… TaskEstimator (#564) ## Stack 1. #564 <- you are here 2. #567 3. #568 4. #569 5. #570 --- Introduces an event-driven API for reacting to distributed planning lifecycle events, and replaces the previous TaskEstimator methods with it. ## Motivation - We need to extend existing methods with new capabilities without imposing those changes on unrelated implementations. For example #569. - We need to add new event handlers without turning `TaskEstimator` into a generic bucket for every planner lifecycle hook. For example #570. - We could be expressing current behavior in terms of just event handler implementations, instead of inlining it in the code, for example: #567. - Converge into a single pattern all the user extension points, instead of having different shape of APIs for them. For example: #568 `TaskEstimator` was a convenient initial extension point, but its methods run at different points in planning, observe different context, and have different result semantics. Task-count estimation is evaluated while traversing the plan; leaf specialization only runs after a stage's final task count is known; routing runs later on the coordinator. Keeping these operations in one trait couples otherwise independent APIs. This event-specific pattern is easier to extend without breaking API consumers: a capability can evolve within the event that owns it instead of requiring every `TaskEstimator` implementation to adopt a broader trait. It is also easier to document and expose to users. Dedicated event types give us focused API pages and code documentation, and provide a quick index of the project’s extension points by the planner lifecycle events where users can hook their code. ## What changed Previously, one trait covered task-count estimation, leaf specialization, and task routing: ```rust trait TaskEstimator { fn task_estimation(&self, plan: &Arc<dyn ExecutionPlan>, cfg: &ConfigOptions) -> Option<TaskEstimation>; fn scale_up_leaf_node(&self, plan: &Arc<dyn ExecutionPlan>, task_count: usize, cfg: &ConfigOptions) -> Result<Option<Arc<dyn ExecutionPlan>>>; fn route_tasks(&self, ctx: &TaskRoutingContext<'_>) -> Result<Option<Vec<Url>>>; } ``` The old API registered one implementation containing every hook: ```rust SessionStateBuilder::new() .with_distributed_task_estimator(MyTaskEstimator); ``` Those phases now have dedicated event handlers, which can be ordinary functions and are registered independently: ```rust fn desired_task_count( _event: DesiredTaskCountEvent, ) -> Option<DesiredTaskCountEventResponse> { None } fn scale_up_leaf_node( _event: ScaleUpLeafNodeEvent, ) -> Option<Result<ScaleUpLeafNodeEventResponse>> { None } fn route_tasks( _event: RouteTasksEvent, ) -> Option<Result<RouteTasksEventResponse>> { None } SessionStateBuilder::new() .with_distributed_desired_task_count_handler(desired_task_count) .with_distributed_scale_up_leaf_node_handler(scale_up_leaf_node) .with_distributed_route_tasks_handler(route_tasks); ```
gabotechs
force-pushed
the
gabrielmusat/async-desired-task-count
branch
from
July 28, 2026 15:14
a6ac3d4 to
a5e0b27
Compare
gabotechs
force-pushed
the
gabrielmusat/dynamic-stage-built-events
branch
from
July 28, 2026 15:14
700d9ca to
7fbb1b4
Compare
gabotechs
added a commit
that referenced
this pull request
Jul 31, 2026
## Stack 1. #564 2. #567 <- you are here 3. #568 4. #569 5. #570 --- Moves routing policy into ordered `RouteTasksHandler`s. Built-ins now cover child co-location, coordinator co-location, and randomized fallback, while custom handlers can override them. ```rust config.with_distributed_route_tasks_handler(|event| { Some(Ok(RouteTasksEventResponse::new( vec![worker_url.clone(); event.task_count], ))) }); ``` --------- Co-authored-by: Jayant Shrivastava <jshrivastava03@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Adds
DynamicStageBuiltHandler, called whenever dynamic planning builds a stage. A handler can inspect cost and the outgoing plan, rewrite it, or abort execution.